← docsCode Quality

/review

Standard PR review — diff-driven, evidence-based.

Standard pull request review contract. Diff-driven, evidence-based, with pass/fail gates. Lighter than thermo-nuclear — suited for day-to-day merges and routine code review.

Category

Code Quality

Execution

Diff → findings → verdict

Goal

Review a pull request diff and produce a verdict with cited findings.

Scope

Applies to

  • +Open PRs with a diff
  • +Day-to-day code review

Does not cover

  • −Architecture review (use thermo-nuclear)
  • −Pre-commit hooks

Triggers

"Review this PR""Code review""Review my changes"

Inputs

  • →baseBranch: develop or main
  • →diff scope: PR commits only
  • →PR description (required)

Invariants

  • 01Never modify files outside the diff
  • 02Every finding cites line numbers
  • 03No stylistic opinions — only correctness and maintainability

Procedure

  1. Step 1Read the PR description for context
  2. Step 2Run git diff against base branch
  3. Step 3Analyze each changed file: correctness, security, tests
  4. Step 4Collect findings with severity
  5. Step 5Issue verdict: PASS or FAIL

Outputs

  • ▸findings.md: numbered list with file:line, severity, description
  • ▸verdict: PASS or FAIL

Review Gate

  • [ ]Every finding has a file:line citation
  • [ ]No finding is a stylistic preference
  • [ ]Verdict matches finding severities
  • [ ]No file outside diff was touched